Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing protected branch #6

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

testing protected branch #6

wants to merge 1 commit into from

Conversation

ryantanaka
Copy link

added TEST.txt to the dev branch on my repository

Copy link
Member

@carlosparadis carlosparadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing approved review

@carlosparadis
Copy link
Member

@ryantanaka ok it wont allow without my accepted review (or anyone's), what does it show now to you? is the merge button green to you?

@ryantanaka
Copy link
Author

The merge button is not green. It looks like this on my end.

screenshot from 2017-09-06 14-37-29

@carlosparadis
Copy link
Member

@ryantanaka Great, it is working how I intended it to. This should avoid slips! Also, how is wiki side? Can you edit and create pages?

@ryantanaka
Copy link
Author

awesome! i created and saved a test wiki page on survey_display_local, but was unable to on survey_display_server since there is no wiki in it yet. can you create one? and I'll try make a test wiki there.

@ryantanaka
Copy link
Author

sorry it works, I just forgot to accept the invitation -__-

@carlosparadis
Copy link
Member

Which invitation you didn't accept?

Also did you try sending a commit directly to the repo without being via pull request? Did you get denied?

@ryantanaka
Copy link
Author

@carlosviansi sorry for the confusion, I commented on this issue and not here.

And I forgot to accept the invitation for survey_display_server before trying to create a wiki there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants