Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the System.IO.Abstractions reference to version 17.2.3 or above #7

Closed
IgorMS-GH opened this issue Nov 6, 2022 · 5 comments · Fixed by #10
Closed

Please update the System.IO.Abstractions reference to version 17.2.3 or above #7

IgorMS-GH opened this issue Nov 6, 2022 · 5 comments · Fixed by #10
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@IgorMS-GH
Copy link

Using EQXMedia.TxFileSystem in conjunction with a direct reference to System.IO.Abstractions in version 16.x or 17.x leads to a

System.TypeLoadException: Method 'CreateSymbolicLink' in type 'EQXMedia.TxFileSystem.TxFile' from assembly 'EQXMedia.TxFileSystem, Version=2.1.1.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

because several interfaces in System.IO.Abstractions have been extended with additional methods since version 13.2.9.

@jarnokamminga
Copy link
Member

@IgorMS-GH, I will make sure this gets in a new release soon.

@jarnokamminga jarnokamminga self-assigned this Nov 10, 2022
@jarnokamminga jarnokamminga added this to the Version 2.2.0 milestone Nov 10, 2022
@jarnokamminga
Copy link
Member

These changes have already been made and have been merged into dev yesterday, @IgorMS-GH .

However, code coverage should be increased again, for it to become part of the upcoming release.

@jarnokamminga jarnokamminga linked a pull request Nov 11, 2022 that will close this issue
@jarnokamminga jarnokamminga added the enhancement New feature or request label Nov 11, 2022
@IgorMS-GH
Copy link
Author

These changes have already been made and have been merged into dev yesterday, @IgorMS-GH .

However, code coverage should be increased again, for it to become part of the upcoming release.

Thanks for your quick reaction.
I'm really looking forward to the upcoming 2.2.0 release.

jarnokamminga added a commit that referenced this issue Nov 11, 2024
Added support for .NET 6, .NET 7, .NET 8 and symbolic links. Fixes #7.
@jarnokamminga
Copy link
Member

@IgorMS-GH, when you upgrade to 3.0.0-beta1 you can use those methods now too.

In the near future I will be adding support for even more recent versions of System.IO.Abstractions.

@IgorMS-GH
Copy link
Author

👍 for resuming development on this package and updating the Systems.IO.Abstractions dependency.
I have to confess that I've moved on to later versions than 17.2.3 in the meantime. I'd therefore very much appreciate your supporting even more recent versions.
I'm also wondering if you will consider switching to the TestableIO.System.IO.Abstractions / TestableIO.System.IO.Abstractions.Wrappers pair which introduces a separation between interfaces and (default) implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants