Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update location of testkomodo.sh #430

Merged
merged 1 commit into from
May 16, 2023
Merged

Update location of testkomodo.sh #430

merged 1 commit into from
May 16, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented May 11, 2023

The location inside jenkins has been deprecated in komodo-releases

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate labels

@berland berland added the maintenance Not a bug now but could be one day label May 11, 2023
@berland berland self-assigned this May 11, 2023
@xjules
Copy link
Contributor

xjules commented May 11, 2023

There we go!

>           raise TimeoutException(message) from err
E           selenium.common.exceptions.TimeoutException: Message: text -> Value not found within 20s, #response-overview-ResponseCorrelation-4 text.ytitle not found

@xjules xjules closed this May 15, 2023
@xjules xjules reopened this May 15, 2023
@berland
Update location of testkomodo.sh
c0e7b3f 
The location inside jenkins has been deprecated in komodo-releases
@berland berland force-pushed the update_testkomodosh_location branch from c96fd6b to c0e7b3f Compare May 16, 2023 12:16
@berland berland requested a review from xjules May 16, 2023 12:29
@hnformentin hnformentin self-requested a review May 16, 2023 13:03
hnformentin
hnformentin approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@hnformentin hnformentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berland berland merged commit 4660382 into main May 16, 2023
@berland berland deleted the update_testkomodosh_location branch May 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hnformentin hnformentin hnformentin approved these changes

@xjules xjules Awaiting requested review from xjules

Assignees

@berland berland

Labels
maintenance Not a bug now but could be one day
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berland @xjules @hnformentin