Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test on self-hosted runner #419

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix flaky test on self-hosted runner #419

merged 1 commit into from
Mar 1, 2023

Conversation

kwinkunks
Copy link
Member

One of the Selenium tests on a plot axis title was sometimes timing out. This change doubles the timeout to 20s. For sure, 10s already seems long; if there's still an issue it may be another problem.

Issue
Resolves #418

Approach
Double the length of the timeout.

Pre review checklist

  • Added appropriate labels

@kwinkunks
Fix flaky test on self-hosted runner
a6c2179 
One of the Selenium tests on a plot axis title was sometimes
timing out. This change doubles the timeout to 20s. For sure,
10s already seems long; if there's still an issue it may be
another problem.
@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

@kwinkunks kwinkunks marked this pull request as ready for review February 28, 2023 14:25
@kwinkunks kwinkunks requested a review from xjules February 28, 2023 14:25
@berland
Copy link
Contributor

berland commented Feb 28, 2023

The other dash_duo.wait_for_text_to_equal() in the same file, should they have a specific timeout as well, or is it only this one that has triggered failures?

@kwinkunks
Copy link
Member Author

@berland So far I've only seen the test fail at this line. My impression is that after select_by_name() there is only one plot, and each wait_for_text_to_equal() is just looking at it. So I thought that perhaps only the first one might need to wait a bit longer for the plot to render.

berland
berland approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a try!

@kwinkunks kwinkunks merged commit ecc3ad2 into equinor:main Mar 1, 2023
@kwinkunks kwinkunks deleted the fix-flaky-timeout branch March 1, 2023 09:21
@kwinkunks kwinkunks mentioned this pull request Mar 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

@xjules xjules Awaiting requested review from xjules

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky test on self-hosted runner
3 participants
@kwinkunks @ertomatic @berland