register pytest mark #409
Merged
register pytest mark #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
berland
reviewed
Feb 6, 2023
pyproject.toml
Outdated
| addopts = "-k 'not spe1'" | ||
| addopts = "-m 'not spe1'" | ||
| markers = [ | ||
| "spe1: marks tests needing results from ert forward model spe1", |
There was a problem hiding this comment.
to be pedantic, maybe rephrase to "from ert model of the spe1 test case".
(an ert model consists (usually) of multiple forward models, and spe1 is really an external thing from Society of Petroleum Engineers)
berland
approved these changes
Feb 6, 2023
The mark is present in the tests but not registered. This commit registers it in pyproject.toml and uses it for the default test selection instead of -k.
cb8be6f to
44145ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mark is present in the tests but not registered. This commit registers it in
pyproject.tomland uses it for the default test selection instead of -k.Issue
Resolves #408
Approach
Register the mark in the init file.
Pre review checklist