ENH: Add FLUID column and simplify column names in inplace_volumes #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94da8ad to
251ff54
Compare
tnatt
commented
Dec 12, 2024
| @@ -24,7 +25,17 @@ | |||
| _logger: Final = null_logger(__name__) | |||
|
|
|||
|
|
|||
| _TABLE_INDEX_COLUMNS: Final = ("ZONE", "REGION", "FACIES", "LICENCE") | |||
| _TABLE_INDEX_COLUMNS: Final = ("ZONE", "REGION", "FACIES", "LICENSE") | |||
There was a problem hiding this comment.
typo in LICENSE fixed
There was a problem hiding this comment.
I think this was not your typo:
fmu-dataio/src/fmu/dataio/_definitions.py
Line 73 in 61d17d4
We probably want to change this too? Doesn't need to be in your PR
There was a problem hiding this comment.
👍 I'll make an issue of it, and also state that we should add FLUID in there
251ff54 to
241edd1
Compare
mferrera
approved these changes
Dec 13, 2024
efe0048 to
2e30e5e
Compare
2e30e5e to
f0ba7c0
Compare
tnatt
added a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add a FLUID column to the exported inplace_volumes table.
There will be more tests of the table format coming in upcoming PR #900
Closes #903