Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add 'simulationtimeseries' content type #897

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Dec 6, 2024

Resolves #689

Rationale for new content type: 'simulationtimeseries' is more of a super-type of 'timeseries' than a subtype since it can contain multiple timeseries vectors.

@mferrera mferrera self-assigned this Dec 6, 2024
@mferrera mferrera force-pushed the add-simulationtimeseries-content branch 2 times, most recently from eaf4aed to 395c932 Compare December 6, 2024 08:05
@mferrera mferrera marked this pull request as ready for review December 6, 2024 08:09
@mferrera mferrera requested review from tnatt and jcrivenaes December 6, 2024 08:09
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully support this as a separate content 👍

@mferrera mferrera force-pushed the add-simulationtimeseries-content branch from 395c932 to 1ee1966 Compare December 6, 2024 10:26
@mferrera mferrera merged commit 674b155 into equinor:main Dec 6, 2024
15 checks passed
@mferrera mferrera deleted the add-simulationtimeseries-content branch December 6, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using summary as content
2 participants