CLN: Remove last usages of the Any type #489
Conversation
There was a problem hiding this comment.
This looks OK to me, but I think it may be best to have @jcrivenaes or @perolavsvendsen weigh in on it as well
| @@ -699,6 +704,9 @@ def _get_columns(self) -> list[str]: | |||
| columns = list(self.obj.columns) | |||
| else: | |||
| logger.debug("arrow") | |||
| from pyarrow import Table | |||
There was a problem hiding this comment.
I wonder if and when these lazy imports start to become numerous enough to bite us later on... the import doesn't seem excessively slow to my mind, about half a second (at least as far as Python is concerned). Probably few enough to be OK now, but will there be more?
There was a problem hiding this comment.
Ive wondered so as well. But i think for now, its fine. But if i go back and look at older versions it looks like there was a period of time where we could not really upon pyarrow being installed.
| @@ -176,7 +185,7 @@ def _get_path(self) -> tuple[Path, Path | None]: | |||
|
|
|||
| def _get_path_generic( | |||
| self, | |||
| mode: Literal[FmuContext.REALIZATION, FmuContext.PREPROCESSED], | |||
| mode: FmuContext, | |||
There was a problem hiding this comment.
Discussed with @jcrivenaes ✅
Extends: #484