CLN: Use AllowedContent to deduce if field is composite #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
commented
Feb 16, 2024
|
|
||
| # This setting sets the FMU context for the output. If detected as a non-fmu run, | ||
| # the code will internally set actual_context=None | ||
| ALLOWED_FMU_CONTEXTS: Final = { |
janbjorge
commented
Feb 16, 2024
| CONTENTS_REQUIRED: Final = { | ||
| "fluid_contact": {"contact": True}, | ||
| "field_outline": {"contact": False}, | ||
| "field_region": {"id": True}, |
There was a problem hiding this comment.
Minor bug discovered, the fields property and seismic should have been a part of this. (Confirmed with @jcrivenaes )
There was a problem hiding this comment.
Bug, but will keep it as is for now. A FutureWarning has been added.
janbjorge
commented
Feb 16, 2024
janbjorge
commented
Feb 16, 2024
janbjorge
commented
Feb 16, 2024
src/fmu/dataio/_definitions.py
Outdated
| SCHEMA: Final = ( | ||
| "https://main-fmu-schemas-prod.radix.equinor.com/schemas/0.8.0/fmu_results.json" | ||
| ) | ||
| VERSION: Final = "0.8.0" | ||
| SOURCE: Final = "fmu" | ||
|
|
||
|
|
||
| class ValidationError(ValueError, KeyError): |
There was a problem hiding this comment.
Bad merge? ValidationError is defined in two places.
janbjorge
commented
Feb 23, 2024
| @@ -71,3 +71,39 @@ class AllowedContent(BaseModel): | |||
| relperm: None = Field(default=None) | |||
| lift_curves: None = Field(default=None) | |||
| transmissibilities: None = Field(default=None) | |||
|
|
|||
| @staticmethod | |||
| def requires_additional_input(field: str) -> bool: | |||
There was a problem hiding this comment.
This can go away once we make a switch "further up", cheep workaround for now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #474