CLN: Add dataclass DerivedNamedStratigraphy #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbjorge
commented
Feb 13, 2024
Comment on lines
-175
to
-176
| def __post_init__(self) -> None: | ||
| logger.info("Ran __post_init__") |
There was a problem hiding this comment.
Seems unnecessary to me.
janbjorge
commented
Feb 13, 2024
Comment on lines
185
to
186
| if not no_start_or_missing_name and rv.name != "name": | ||
| rv.alias.append(name) |
There was a problem hiding this comment.
Can be moved inside the above function block by usage of walrus op. But gets unreadable.
| metadata: dict = field(default_factory=dict) | ||
| name: str = field(default="") | ||
| specs: dict = field(default_factory=dict) | ||
| subtype: str = field(default="") |
There was a problem hiding this comment.
This PR is split out off #469 looks like i missed this one. Typically we get something like below. But for now, it seems like it not used/propagated.
DerivedObjectDescriptor(
subtype="CPGridProperty",
classname="cpgrid_property",
perolavsvendsen
approved these changes
Feb 13, 2024
Correct, there should be no new logical changes here. Expect for that we now use a dataclass insted of a dict to communicate between functions/classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adressess: #457