feat: re-add class_commitment to pathfinder_getProof output #2491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2489
I compared results between 15bdee2 and this branch and there's some differences:
pathfinder_getProof
serialized missingcontract_data
asnull
, now it's just skipped - I guess we should stick to the old behavior?contract_proof
nodes were serialized in a slightly different way:as compared to
now.
Looking at the old code one would say that there's
skip_serializing_none
and thenull
-s should not appear in the output, but this is a bug, because the annotation must be put before the derive.I think these differences should also be addressed. Wdyt?