feat(rpc): Move away from serde in RPC DTO's (in favor of our own [De]SerializeForVersion)
#2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180ed9c to
68b84ba
Compare
kkovaacs
approved these changes
Dec 20, 2024
…in favor of our `SerializeForVersion` and `DeserializeForVersion` traits
68b84ba to
ef72a91
Compare
feat(rpc): remove `deserialize_serde` for primitives and common types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #2220
Summary
This PR removes mostly all
serde::Serializeandserde::Deserializepresent in our DTO structs, replacing them with ad-hoc implementations ofSerializeForVersionandDeserializeForVersion.Note: For those types that don't necessarily need
Deserializecapabilities other than incfg(test), I've tried to keep theserdeattributes for completeness, although most tests pass without them.