-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proof): pathfinder_getClassProof endpoint #2179
feat(proof): pathfinder_getClassProof endpoint #2179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see nothing objectionable, but @kkovaacs is our trie expert.
Also not sure if something like this will be in the v0.8 spec maybe, so this endpoint won't be necessary anymore. There's a PR open for this in the specs repo. (I understand you may already be aware of this.)
Hey @kkovaacs! I addressed your comments and update to latest main. |
@kkovaacs sorry I had a misconfiguration locally, now everything should be fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this!
Also, please note that the JSON-RPC 0.8.0 specification will have this functionality as part of its starknet_getProof
method.
Added a new endpoint
pathfinder/v0.1/pathfinder_getClassProof
that returns the Merkle proof of any class hash in the class trie.This new endpoint is necessary to run the Starknet OS to completion as we need the full class commitment as input of the OS.