Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proof): pathfinder_getClassProof endpoint #2179

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

odesenfans
Copy link
Contributor

Added a new endpoint pathfinder/v0.1/pathfinder_getClassProof that returns the Merkle proof of any class hash in the class trie.


This new endpoint is necessary to run the Starknet OS to completion as we need the full class commitment as input of the OS.

@odesenfans odesenfans requested a review from a team as a code owner August 21, 2024 11:42
Copy link
Contributor

@sistemd sistemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing objectionable, but @kkovaacs is our trie expert.

Also not sure if something like this will be in the v0.8 spec maybe, so this endpoint won't be necessary anymore. There's a PR open for this in the specs repo. (I understand you may already be aware of this.)

@sistemd sistemd requested a review from kkovaacs August 22, 2024 20:09
@HermanObst
Copy link
Contributor

Hey @kkovaacs! I addressed your comments and update to latest main.
Im getting a spurious clippy error, but the rest looks good :)

@HermanObst
Copy link
Contributor

@kkovaacs sorry I had a misconfiguration locally, now everything should be fine :)

Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this!

Also, please note that the JSON-RPC 0.8.0 specification will have this functionality as part of its starknet_getProof method.

@kkovaacs kkovaacs merged commit da0a0bf into eqlabs:main Oct 3, 2024
7 checks passed
@HermanObst HermanObst deleted the od/rpc/feat/get-class-proof branch October 3, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants