Improvements and style #151
Conversation
|
that's not funny... apt-things are broken again 😞 |
|
Request for Comments … @tuxmea @nmesstorff @michael-os |
| ensure => directory, | ||
| owner => 'oneadmin', | ||
| group => 'oneadmin', | ||
| mode => '0755', |
There was a problem hiding this comment.
Please keep the mode in place.
You might get trouble when umask is set to a more restrictive setting.
|
thanks for the input... i will have a closer look at these things in the next days |
| ensure => directory, | ||
| owner => 'oneadmin', | ||
| group => 'oneadmin', | ||
| require => File['/var/lib/one'], |
There was a problem hiding this comment.
What is this require good for? As far as I understood, file and directory resources have automatic dependency if one is contained within the other?
|
Overall a very nice improvement to the module, thx for putting effort into this! I should add: I didn't have a look at all spec tests, but the module changes themselves looked find except for the existing comments. |
|
have to rebase this one and will merge than... |
- add one::compute_node::config tests - add one::compute_node::install tests - add one::compute_node tests
- move os_facts to a constant in the spec_helper - move all require statements to the spec_helper - do a code reformat
- adjust test for new behavior
- add mode for directories - remove unnecessary requires - add parameter to main class - remove hasstatus and hasrestart from services
Had some time while traveling, so i reworked the module. Did some reordering, style fixes and added parameters to all the classes, so that you can test them one by one. Added some spec tests, but not for all the classes. Changed the behavior of the big over-all-test. merge the deb and the rhel version into one file.