Update probability_*() functions
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se dyn-dots and call .fit
…res and updates test reference values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
probability_*()functions (probability_epidemic(),probability_extinct()andprobability_contain()) from comments from #77.Changes include:
probability_epidemic()has been moved toprobability_extinct()as it is slightly simpler, andprobability_epidemic()is now a wrapper function..fit(). This allows either numerical optimisation (usingoptim()) or the original grid search implementation.probability_*()functions now accept dynamic dots and {rlang} has been taken on a package dependency..fit()and reference values for other tests are updated.%||%operator has been added to the package.Smaller changes include: the
proportion_*()function documentation is updated as they do not have dynamic dots, new tests forprobability_epidemic(), and updating the CITATION.cff and WORDLIST.