Add option for numeric proportions
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #69 by adding a new argument to
proportion_*()functions:format_prop. The default behaviour of the function remains the same, formatting the proportions returned in the<data.frame>(format_prop = TRUE), but this argument now allows users to turn off the formatting (format_prop = FALSE) and the proportions column(s) of the output<data.frame>will benumeric.The design principles vignette is updated explaining the thought behind the added flexibility of output types.
Tests have been added to check the new functionality and the function documentation is also updated.