-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design principles vignette #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @joshwlambert. This looks great.
Is it worth at this point reconsidering whether it would make merge this and <epichains>
into a single package that revolves around analysis and interpretation of infectious disease data with branching process models? The main reason I'm thinking that this could make sense is that the two have somewhat circular dependencies: the mixture probability distributions implemented here would be useful in <epichains>
(which already implements a gamma/Borel mixture) as would the functions for providing secondary analysis given parameters of a negative binomial - whereas this package itself depends on <epichains>
/<bpmodels>
for simulation.
If I remember correctly we previously decided to keep them separate as <bpmodels>
was transitioning into <epichains>
when this package came into existence but as this transition is mostly complete it might be a good time to come back to this.
cc @jamesmbaazam and @adamkucharski for thoughts.
Agree makes sense to reconsider whether better as single package as a 'one stop shop' for branching analysis – currently |
Great. Just to note that I've edited my initial comment having realised that none of the package names had been rendered - hopefully makes a bit more sense now. |
Thanks for the comments. I'm open to the merger. I think for now it would benefit both packages to reach stability and then be merged. Therefore, I propose we wait until after {epichains} has been reviewed and released and another {superspreading} release, and then we can coordinate a possible merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Josh. I like that the document is very clear about the scope of the package. I've always wondered if this document is also a good place to compare other related packages.
01f3a74
to
e1b7eba
Compare
Thanks for your inputs, all. I do think that merging the two packages would be a good idea because they have enough overlap. Additionally, a single package would be easier to maintain since any breaking changes in {epichains} would affect {superspreading}. If the agreement is to merge it, I would suggest holding off another release of {superspreading} and rather merging it into {epichains} before the v0.1.0 release in the new year. We can then jointly supersede {bpmodels} and {superspreading}. |
Thanks for all the input. I will merge this PR once all checks pass. I think the discusson on merging should be continued elsewhere. |
This PR addresses #28 by adding a design principles vignette. This vignette outlines the scope of the package, the function signatures and naming convention, as well as the function return types, it covers development design decisions and some explanation to package dependencies.