Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vignette on proportion_transmission() methods #101

Merged
merged 11 commits into from
Sep 27, 2024
Merged

Add vignette on proportion_transmission() methods #101

merged 11 commits into from
Sep 27, 2024

Conversation

joshwlambert
Copy link
Member

This PR adds a new vignette to the package explaining the two methods included in the proportion_transmission() function since #99. This PR relates to #93 and uses code kindly provided by @dcadam.

@joshwlambert joshwlambert added the documentation Improvements or additions to documentation label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@github-actions GitHub Actions
Copy link

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@github-actions GitHub Actions
Copy link

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@github-actions GitHub Actions
Copy link

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@joshwlambert joshwlambert marked this pull request as ready for review September 10, 2024 13:04
@joshwlambert joshwlambert mentioned this pull request Sep 10, 2024
Closed
adamkucharski
adamkucharski approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@adamkucharski adamkucharski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice, thanks. Have made some edits for clarity and readability, especially as it's conceptually quite a subtle difference.

@joshwlambert @adamkucharski
Update text in proportion_transmission vignette
1762adf 
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
@github-actions GitHub Actions
Copy link

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@github-actions GitHub Actions
Copy link

This pull request:

  • Adds 3 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

(Note that results may be inacurrate if you branched from an outdated version of the target branch.)

@joshwlambert joshwlambert merged commit 1ccf18e into main Sep 27, 2024
9 checks passed
@joshwlambert joshwlambert deleted the prop-trans-vig branch September 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkucharski adamkucharski adamkucharski approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwlambert @adamkucharski @actions-user