Fix time delay bug #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #92 by finding and fixing an error in the
.sim_network_bp()function. Previously, the time delay between contacts (which also then influenced times of hospitalisation and death) were not being correctly added to the time of their ancestor due to a vector indexing bug. This PR attempts to fix this by correctly indexing the ancestors time of infection and adds the new time delay of the newly infected individual.This should resolve the issue raised in #92 that the distribution of times of an outbreak is only a few days even when modifying the simulation parameters.
Snapshots for tests of
sim_*()function have been updated with the new dates from the fix.