Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint-changed-files CI for {lintr} v3.2.0 #195

Merged
merged 11 commits into from
Feb 19, 2025
Merged

Fix lint-changed-files CI for {lintr} v3.2.0 #195

merged 11 commits into from
Feb 19, 2025

Conversation

joshwlambert
Copy link
Member

This PR fixes lintr warnings - causing the lint-changed-files workflow to fail - since the release of {lintr} v3.2.0. Most issues detected have been resolved, some have # nolint flags, where deemed better to keep the existing code, these can potentially be resolved and the # nolint flag removed in the future.

Changes include:

  • Adding a dot prefix to variables assigned in functions that overwrite functions exported by base R, e.g. .args
  • Remove all() from stopifnot() calls as this is done automatically
  • Unnest else after return()
  • All lines are less than 80 characters
  • Use sample.int() instead of sample()

Add # nolint flags for:

  • one_call_pipe_linter
  • consecutive_mutate_linter

@joshwlambert joshwlambert added internal Updates that only change internal functions CI Updates involving continuous integration labels Feb 19, 2025
@joshwlambert
Copy link
Member Author

The pkgdown workflow is now failing on this PR. It was passing on main and I've just re-run the workflow on the HEAD of main and it passes, so it is possible it is due to an issue introduced in this PR.

@joshwlambert
Copy link
Member Author

pkgdown::build_site() runs successfully locally, so I'm going to assume/hope this is an intermittent issue with GitHub actions and if not fix in a separate PR.

One step forward, one step backwards...

@joshwlambert joshwlambert merged commit 2c9faff into main Feb 19, 2025
8 of 9 checks passed
@joshwlambert joshwlambert deleted the fix-lint branch February 19, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Updates involving continuous integration internal Updates that only change internal functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant