Update extract_param()
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aram, fit_range and fit_percentiles, and removed optim_conv from check_optim_cov
…xtraction and allow negative vals for normal, relates #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
extract_param()function and it's internal functions. It is based on comments raised in #151 and includes the development to include extraction of parameters for a normal distribution suggested in #157.Changes to internal functions include:
extract_param_percentiles()andextract_param_range()into.extract_param()fit_function_gamma(),fit_function_lnorm(),fit_function_weibull()intofit_percentiles()fit_function_gamma_range(),fit_function_lnorm_range(),fit_function_weibull_range()intofit_range()optim_convargument fromcheck_optim_conv()The vignettes are updated to make clear that extraction for normal distributions is now included in the package. The documentation and testing is updated as well.