-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce NAMESPACE of conversion functions #164
Comments
…and moved lower-level internal, WIP #164
…ed new tests for new functions, WIP #164
When this issue was raised in #151 it was mentioned that the function could be dispatched based on the input with the example: epiparam() |>
mutate(params = convert_summary_stats(prob_distribution, mean, sd)) Therefore, it would be good to check if these conversion functions could be turned into S3 generics and dispatched on |
PR #165 implements the major change requested in this issue, therefore, I will merge this PR before making the change to implement |
…and moved lower-level internal, WIP #164
…ed new tests for new functions, WIP #164
…and moved lower-level internal, WIP #164
…ed new tests for new functions, WIP #164
Currently there are a few conversion functions in {epiparameter}:
It was raised in #151 that it would be better to reduce the number of conversion functions and instead have a few general functions that encapsulate this functionality. This will reduce the API of the package, be easier to maintain and scale better if we want to add more conversions in the future.
The text was updated successfully, but these errors were encountered: