Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Update Faraday to v1.0 #17

Merged
merged 12 commits into from
Jan 22, 2020
Merged

Update Faraday to v1.0 #17

merged 12 commits into from
Jan 22, 2020

Conversation

epistrephein
Copy link
Owner

@epistrephein epistrephein commented Jan 10, 2020

Pull Request description

  • Update the minimum version of faraday dependency to v1.0
  • Remove faraday_middleware dependency and use native JSON lib to parse responses
  • Bump minimum Ruby version to 2.3
  • Remove sudo: false from .travis.yml (Explanation)
  • Update RuboCop version of Hound to 0.75 and remove Gemspec/RequiredRubyVersion rule
  • Minor style fixes

Pull Request checklist

Kind of change
  • My code is a minor change (typos, configuration, anything not related to core functionality)
  • My code is a bug fix (non-breaking change which fixes an issue)
  • My code is a new feature (non-breaking change which adds functionality)
  • My code introduces a breaking change (fix or feature that would break existing functionality)
Style and tests
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
Documentation
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
Changelog
  • I have included the CHANGELOG entry for the changes

- Remove faraday_middleware and use native JSON lib to parse responses
- Bump minimum Ruby version to 2.3
@epistrephein epistrephein added the dependencies Libraries depended upon label Jan 10, 2020
@epistrephein epistrephein self-assigned this Jan 10, 2020
@epistrephein epistrephein added the blocked Waiting on something else to be done first label Jan 10, 2020
@epistrephein
Copy link
Owner Author

epistrephein commented Jan 10, 2020

On hold until official GitHub release of Faraday v1.0.
Released: v1.0.0

@epistrephein epistrephein added this to the v2.0 milestone Jan 11, 2020
@epistrephein epistrephein removed the blocked Waiting on something else to be done first label Jan 22, 2020
@epistrephein epistrephein merged commit 8bddada into master Jan 22, 2020
@epistrephein epistrephein deleted the faraday-1.0 branch January 22, 2020 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Libraries depended upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant