Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always remember to flush #147

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Always remember to flush #147

merged 5 commits into from
Feb 2, 2025

Conversation

ravibandaru-lab
Copy link
Collaborator

The lack of output_file.flush() would create incorrect outputs on run of filter-file.

Also refactored for readability.

@ravibandaru-lab ravibandaru-lab self-assigned this Jan 31, 2025
@ravibandaru-lab ravibandaru-lab added the bug Something isn't working label Jan 31, 2025
jamesli124
jamesli124 approved these changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@jamesli124 jamesli124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jamesli124 jamesli124 merged commit 11dfb34 into main Feb 2, 2025
8 checks passed
@jamesli124 jamesli124 deleted the ravibandaru-lab-patch-1 branch February 17, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesli124 jamesli124 jamesli124 approved these changes

Assignees

@ravibandaru-lab ravibandaru-lab

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravibandaru-lab @jamesli124