Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna error #1172

Closed
Derranion opened this issue Oct 21, 2021 · 5 comments
Closed

Lerna error #1172

Derranion opened this issue Oct 21, 2021 · 5 comments
Assignees
Labels
BUG Something isn't working

Comments

@Derranion
Copy link
Member

Derranion commented Oct 21, 2021

  • What is the expected behavior?
    Learna should execute pre-commit commands correctly.

  • What is the current behavior?
    Learna throws some errors and fails to execute not letting to commit to the project.

  • Example:
    LEANa error
    LERNa bubble

Side notes:
Looks like it is mostly caused by this:
vue-cli-service lint --fix: vuestic-ui: error: Expected 'undefined' and instead saw 'void' (no-void) but we do not have void checks in the source code.

Find out how it could be resolved.

@Derranion Derranion added the BUG Something isn't working label Oct 21, 2021
@Derranion Derranion self-assigned this Oct 21, 2021
@Derranion
Copy link
Member Author

Derranion commented Oct 22, 2021

Fixed previous errors by no-void check removal because it is completely fine to use it and could be used when project is minified because it is shorter than undefined.

After fixing it we get new errors, working on it:
nextErrorLerna

@Derranion
Copy link
Member Author

Fixed it

m0ksem pushed a commit to m0ksem/vuestic-ui that referenced this issue Oct 25, 2021
m0ksem pushed a commit to m0ksem/vuestic-ui that referenced this issue Oct 29, 2021
@Derranion
Copy link
Member Author

Derranion commented Nov 3, 2021

Looks like this issue has returned - was not able to commit today (exactly the same error).

Most likely ESLint config or its version has been changed somewhere in the recent commits and this broke our previous fix.

@Derranion Derranion reopened this Nov 3, 2021
@Derranion Derranion assigned Derranion and unassigned Derranion Nov 3, 2021
@Derranion
Copy link
Member Author

Update:
Fixed previous error, here is the new one:
preCommit

@Derranion
Copy link
Member Author

There were multiple ESLint errors some of them were caused by this bug, reported it to eslint-plugin-import.
ESLintErrors2

I've fixed it by this commit: Fix #1197, 1172: TimeInput logic moved to setup body, ESLint fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant