Fix mutable parameters of mutable ADTs #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft, because this will only work generally with deep copies of ADTs. |
# Conflicts: # stainless_extraction/src/synth/mod.rs
Disentangle test cases.
24bc9e9 to
1365cc7
Compare
romac
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150 but not the anti-aliasing problems described in #154.
This PR incorporates the fixed version of Stainless that fixes the linked issue. For the anti-aliasing problem of mutable ADTs, an approach of deeply copying the ADT at the start of the function by doing a pattern match and then field-wise copy was tried but abandoned (#155).