Fix bug in parsing hex char escapes #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: the parser would crash if it encountered
"\x5C"
in a grammar. This commit fixes that bug. (There is still a bug I couldn't locate that causes the parser to crash with"\\"
. But the"\x5C"
provides a workaround.)The bug was that the parsing code returned an
int
instead of astr
, as the client code expected.This commit also adds some test cases I used to find the problem.