Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return valid error in status field of GitServer #15

Closed
zmotso opened this issue Sep 26, 2023 · 1 comment
Closed

Return valid error in status field of GitServer #15

zmotso opened this issue Sep 26, 2023 · 1 comment
Assignees
@zmotso

Comments

@zmotso
Copy link
Contributor

zmotso commented Sep 26, 2023

We haven't an error message in the status field, and if GitServer can't create a connection, we need to know what is going wrong.
@zmotso zmotso self-assigned this Sep 26, 2023
@zmotso zmotso moved this to In Progress in KubeRocketCI Sep 26, 2023
epmd-edp pushed a commit that referenced this issue Sep 26, 2023
@zmotso
feat!: Add valid error in status field of GitServer (#15)
67ed1e3 
Removed all unnecessary properties from status as they were not used. Added "error" property to the status for storing errors if the connection wasn't established.

BREAKING CHANGE: removed required fields from the GitServer status. CRD should be updated.

Change-Id: If12029a5e9940f6f439e2face5d4905b6eef2e09
@zmotso
Copy link
Contributor Author

zmotso commented Oct 9, 2023

Added error property to the GitServer status.

@zmotso zmotso closed this as completed Oct 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in KubeRocketCI Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmotso zmotso

Labels
None yet
Projects
KubeRocketCI
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zmotso