Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable subjective account decay time #90

Conversation

ClaytonCalabrese
Copy link
Contributor

@ClaytonCalabrese ClaytonCalabrese commented Apr 8, 2022

Adds new config option subjective-account-decay-time-minutes to Producer Plugin

This value is used to calculate the expired_accumulator_average_window, thus making account decay time configurable. The passed value must be above 0, and defaults to 1440.

The default value for expired_accumulator_average_window remains the same.

@matthewdarwin
Copy link

Can this be changed to >= 30 minutes? (I am testing 30 in production right now)

docs/01_nodeos/03_plugins/producer_plugin/index.md Outdated Show resolved Hide resolved
plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved
plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved
plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved
plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved
plugins/producer_plugin/test/test_subjective_billing.cpp Outdated Show resolved Hide resolved
@heifner heifner changed the title Configurable expired_accumulator_average_window Configurable subjective account decay time Apr 9, 2022
}
fc::microseconds subjective_account_decay_time = fc::minutes(options.at( "subjective-account-decay-time-minutes" ).as<uint32_t>());
EOS_ASSERT( subjective_account_decay_time.count() > 0, plugin_config_exception,
"subjective-account-decay-time-minutes ${dt} must be greater than 0", ("dt", subjective_account_decay_time.to_seconds() * 60));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ 60 not * 60

@ClaytonCalabrese ClaytonCalabrese merged commit 5f59702 into feature/oci_api_phase1 Apr 14, 2022
@ClaytonCalabrese ClaytonCalabrese deleted the enfs23_cc_configurable_expired_accumulator_average_window branch April 15, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants