-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable subjective account decay time #90
Merged
ClaytonCalabrese
merged 7 commits into
feature/oci_api_phase1
from
enfs23_cc_configurable_expired_accumulator_average_window
Apr 14, 2022
Merged
Configurable subjective account decay time #90
ClaytonCalabrese
merged 7 commits into
feature/oci_api_phase1
from
enfs23_cc_configurable_expired_accumulator_average_window
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive_billing.hpp
Can this be changed to >= 30 minutes? (I am testing 30 in production right now) |
heifner
suggested changes
Apr 9, 2022
plugins/producer_plugin/include/eosio/producer_plugin/subjective_billing.hpp
Outdated
Show resolved
Hide resolved
heifner
changed the title
Configurable expired_accumulator_average_window
Configurable subjective account decay time
Apr 9, 2022
heifner
reviewed
Apr 11, 2022
plugins/producer_plugin/include/eosio/producer_plugin/subjective_billing.hpp
Outdated
Show resolved
Hide resolved
…ove unused test variable.
heifner
reviewed
Apr 12, 2022
} | ||
fc::microseconds subjective_account_decay_time = fc::minutes(options.at( "subjective-account-decay-time-minutes" ).as<uint32_t>()); | ||
EOS_ASSERT( subjective_account_decay_time.count() > 0, plugin_config_exception, | ||
"subjective-account-decay-time-minutes ${dt} must be greater than 0", ("dt", subjective_account_decay_time.to_seconds() * 60)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ 60
not * 60
heifner
approved these changes
Apr 12, 2022
ClaytonCalabrese
deleted the
enfs23_cc_configurable_expired_accumulator_average_window
branch
April 15, 2022 15:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new config option subjective-account-decay-time-minutes to Producer Plugin
This value is used to calculate the expired_accumulator_average_window, thus making account decay time configurable. The passed value must be above 0, and defaults to 1440.
The default value for expired_accumulator_average_window remains the same.