[3.1 -> main] Reduce net_plugin handshake messages in case of unavailable blocks #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hake message being sent sync-fetch count times to peer. For example, if the client requested 1000 blocks not available by the node, net_plugin would respond with 1000 handshake messages. Disconnect from peer with benign_other so the peer will move on to a different peer to sync from. This is what we already do for blk_send_branch when a block is not available.
…gs-3.1 [3.1] Reduce net_plugin handshake messages in case of unavailable blocks
oschwaldp-oci
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the full block log is not available, prevent handshake message being sent sync-fetch count times to peer. For example, if the client requested 1000 blocks not available by the node,
net_pluginwould respond with 1000 handshake messages. Disconnect from peer withbenign_otherso the peer will move on to a different peer to sync from. This is what we already do forblk_send_branchwhen a block is not available.Resolves #790