Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] move trace api plugin activation out of tests and into cluster #750

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

ClaytonCalabrese
Copy link
Contributor

Investigate whether Cluster requires Trace API Plugin to be enabled now to work at all. If so, we should just have Cluster automatically add this if not already added instead of requiring most tests to add the launch config params:

traceNodeosArgs = " --plugin eosio::trace_api_plugin --trace-no-abis "

Initial investigation reveals that the requirement stems from whether Cluster.py launch 's function will use bootstrap or bios_bootstrap.

If bootstrap will be called which in turn goes into Node.py and calls publishContract with waitForTransBlock=True and eventually calls getBlockNumByTransId which requires a call to getTransaction and reaches out to cleos with a get transaction_trace command, which requires the Trace API.

If bootstrap is not used, in favor of conditions where bios_bootstrap is used, it may not require the Trace API plugin.

Due to some updates to mandel, trace_api_plugin was needed across a wide number of tests. Previously this was done manually in each test by passing it to extraNodeosArgs. Rather than doing it that way, it is cleaner to activate in cluster, defaulting to --trace-no-abis unless the less common --trace-rpc-abi is passed in from a test.

Resolves #285

…lt to trace-no-abi unless otherwise specified in a test
@ClaytonCalabrese ClaytonCalabrese added 3.2 Candidate OCI OCI working this issue... labels Aug 5, 2022
@ClaytonCalabrese ClaytonCalabrese self-assigned this Aug 5, 2022
tests/large-lib-test.py Outdated Show resolved Hide resolved
@ClaytonCalabrese ClaytonCalabrese merged commit 1f1243d into main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Candidate OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate if Cluster requires Trace API Plugin
2 participants