Replace cleos local abi file test with test harness version. #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Aug 3, 2022
tests/cli_test.py
Outdated
| os.mkdir(data_dir) | ||
| walletMgr = WalletMgr(True) | ||
| walletMgr.launch() | ||
| node = Node('localhost', 8888, nodeId, cmd="./programs/nodeos/nodeos -e -p eosio --plugin eosio::trace_api_plugin --trace-no-abis --plugin eosio::producer_plugin --plugin eosio::producer_api_plugin --plugin eosio::chain_api_plugin --plugin eosio::chain_plugin --plugin eosio::http_plugin --access-control-allow-origin=* --http-validate-host=false " + "--data-dir " + data_dir + " --config-dir " + data_dir, walletMgr=walletMgr) |
There was a problem hiding this comment.
I think this may need --resource-monitor-not-shutdown-on-threshold-exceeded & its own config-dir
There was a problem hiding this comment.
Added resource monitor flag. It has a specified config-dir.
spoonincode
reviewed
Aug 3, 2022
tests/cli_test.py
Outdated
| Utils.Print("Cleanup nodeos data.") | ||
| shutil.rmtree(data_dir) | ||
|
|
||
| ''' |
There was a problem hiding this comment.
any reason to comment this out instead of removing it?
There was a problem hiding this comment.
Forgot this was here after removing other commented code. Removed.
spoonincode
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the cleos local ABI file test with a version implemented using the test harness and actually execute it. The previous version was never executed by the test file.