Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] set prune logs at debug level except for the initial log when enabling pruning #718

Merged
merged 3 commits into from
Aug 3, 2022
Merged

[3.1] set prune logs at debug level except for the initial log when enabling pruning #718

merged 3 commits into from
Aug 3, 2022

Conversation

spoonincode
Copy link
Member

Resolves #775. Log message when enabling pruning will now be at info level, continual logging messages that are rather spammy will be at debug level instead.

@spoonincode spoonincode changed the title [3.1] make prune logs be at debug level except for the initial log when enabling purning [3.1] make prune logs be at debug level except for the initial log when enabling pruning Jul 24, 2022
heifner
heifner suggested changes Jul 25, 2022
View reviewed changes
libraries/chain/block_log.cpp Outdated Show resolved Hide resolved
libraries/state_history/include/eosio/state_history/log.hpp Outdated Show resolved Hide resolved
@spoonincode
Copy link
Member Author

🤦 thanks, after I tested it I probably went back to refactor leaving a line out. I'm deal with it later

@spoonincode spoonincode deleted the tweak_prunning_log_31x branch July 25, 2022 14:22
@spoonincode spoonincode reopened this Jul 26, 2022
@spoonincode
Copy link
Member Author

This approach was a little long winded, but I liked it more than a

if(bool)
  ilog();
else
  dlog();

sort of thing. I couldn't find an existing interface that made it easy to xlog(level, message, args) 😕

@heifner
Copy link
Member

heifner commented Jul 28, 2022

xlog(level, message, args)

You could add it.

heifner
heifner suggested changes Jul 28, 2022
View reviewed changes
libraries/chain/block_log.cpp Outdated Show resolved Hide resolved
@spoonincode spoonincode changed the title [3.1] make prune logs be at debug level except for the initial log when enabling pruning [3.1] set prune logs at debug level except for the initial log when enabling pruning Aug 3, 2022
@spoonincode
Copy link
Member Author

You could add it.

Maybe worthwhile post-3.1

@spoonincode spoonincode merged commit a6d362b into release/3.1.x Aug 3, 2022
@spoonincode spoonincode mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoonincode @heifner