Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] disable appbase's automatic version discovery via git #660

Merged

Conversation

ClaytonCalabrese
Copy link
Contributor

Once upon a time in an eosio version long ago, the sole mechanism to populate the version displayed by, say, nodeos --version was via appbase discovering the version by git describe. At some point we changed this up a bit and the bottom line is that libraries/version is the only location that probes git for creating a string ultimately baked in to the build.

This makes the git describe in appbase a complete waste as its output is never included in to final executables. Since this git describe is run literally every time performing a make, seemed worth the trouble to disable it.

Needs eosnetworkfoundation/mandel-appbase#9

Resolves #442

disable appbase's automatic version discovery via git
@ClaytonCalabrese ClaytonCalabrese self-assigned this Jul 12, 2022
@ClaytonCalabrese ClaytonCalabrese changed the title Merge pull request #10236 from EOSIO/disable_appbase_git_describe [3.2] disable appbase's automatic version discovery via git Jul 12, 2022
@heifner heifner added the OCI OCI working this issue... label Jul 13, 2022
@ClaytonCalabrese ClaytonCalabrese merged commit 3f916d0 into main Jul 13, 2022
@ClaytonCalabrese ClaytonCalabrese deleted the disable_appbase_automatic_version_discovery_git branch July 16, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport: disable appbase's automatic version discovery via git
3 participants