Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] controller::extract_chain_id_from_db() does not properly handle dirty db #647

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[3.2] controller::extract_chain_id_from_db() does not properly handle dirty db #647

merged 2 commits into from
Jul 15, 2022

Conversation

vladtr
Copy link
Contributor

@vladtr vladtr commented Jul 12, 2022

This change adds following logic:

  • all exceptions except system_error are propagated. system_error happens for example if database do not exist and needs to be created
  • if chain_id cannot be retrieved empty variant returned, get replaced with find

@vladtr vladtr linked an issue Jul 12, 2022 that may be closed by this pull request
controller::extract_chain_id_from_db() does not properly handle dirty db #121
Closed
@vladtr vladtr requested a review from heifner July 12, 2022 01:07
@vladtr vladtr self-assigned this Jul 12, 2022
@vladtr vladtr changed the title controller::extract_chain_id_from_db() does not properly handle dirty db [3.2] controller::extract_chain_id_from_db() does not properly handle dirty db Jul 12, 2022
heifner
heifner suggested changes Jul 13, 2022
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@vladtr vladtr merged commit 8e5ac5f into main Jul 15, 2022
@vladtr vladtr deleted the handle-dirty-db branch July 15, 2022 00:52
This was referenced Feb 7, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

Assignees

@vladtr vladtr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controller::extract_chain_id_from_db() does not properly handle dirty db
2 participants
@vladtr @heifner