Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] fix break strict-aliasing rules warnings in get_table_tests.cpp #635

Merged
merged 4 commits into from
Jul 12, 2022
Merged

[3.2] fix break strict-aliasing rules warnings in get_table_tests.cpp #635

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4792324
fix break strict-aliasing rules warning
linh2931 Jul 9, 2022
e8e7a63
Merge branch 'main' into fix-strict-aliasing
linh2931 Jul 12, 2022
017bc24
Merge branch 'main' into fix-strict-aliasing
linh2931 Jul 12, 2022
143fda3
Merge branch 'main' into fix-strict-aliasing
linh2931 Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/get_table_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,15 +580,15 @@ BOOST_FIXTURE_TEST_CASE( get_table_next_key_test, TESTER ) try {
auto res_4 = plugin.get_table_rows(params);
float64_t secdouble_expected_value = ui64_to_f64(5);
BOOST_REQUIRE(res_4.rows.size() > 0);
double secdouble_res_value = res_4.rows[0].get_object()["secdouble"].as<double>();
BOOST_CHECK(*reinterpret_cast<float64_t*>(&secdouble_res_value) == secdouble_expected_value);
float64_t secdouble_res_value = res_4.rows[0].get_object()["secdouble"].as<float64_t>();
BOOST_CHECK(secdouble_res_value == secdouble_expected_value);
BOOST_TEST(res_4.next_key == "7.00000000000000000");
params.lower_bound = res_4.next_key;
auto more2_res_4 = plugin.get_table_rows(params);
float64_t more2_secdouble_expected_value = ui64_to_f64(7);
BOOST_REQUIRE(more2_res_4.rows.size() > 0);
double more2_secdouble_res_value = more2_res_4.rows[0].get_object()["secdouble"].as<double>();
BOOST_CHECK(*reinterpret_cast<float64_t*>(&more2_secdouble_res_value) == more2_secdouble_expected_value);
float64_t more2_secdouble_res_value = more2_res_4.rows[0].get_object()["secdouble"].as<float64_t>();
BOOST_CHECK(more2_secdouble_res_value == more2_secdouble_expected_value);

// float128 secondary key type
params.key_type = "float128";
Expand Down