Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1 -> main] Fix for block producer stuck in coma state #629

Merged
merged 5 commits into from
Jul 11, 2022
Merged

[3.1 -> main] Fix for block producer stuck in coma state #629

merged 5 commits into from
Jul 11, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 9, 2022 •
edited
Loading

Backports: #495 Send handshake for heartbeat/2 if no block (first commit)

  • Send handshake message if we have not seen or sent a block for heartbeat/2.
  • Always send handshake message even if it has not changed since it was last sent.

Additional changes in second commit:

  • Main change is to always start syncing from LIB instead of HEAD.
  • Change default keepalive interval to 10s. Previous default of 32s seems rather excessive given that block time is 500ms.
  • Honor keepalive interval regardless of protocol version since there is nothing that requires a particular protocol version.

Release 3.1.x version #627

linh2931 and others added 5 commits July 7, 2022 20:49
@linh2931 @heifner
Merge pull request #495 from eosnetworkfoundation/more_freq_handshake
b17b624 
Backport: Send handshake for heartbeat/2 if no block -- main
@heifner
GH-623 Start syncing from LIB always even if we have previously synce…
1a05ad4 
…d instead of HEAD since node might be on its own private fork.

Decrease default keepalive interval to 10s. Previous default of 32s seems rather excessive given that block time is 500ms.
Honor keepalive interval for all protocol versions since there is nothing about it that depends on a particular protocol version.
@heifner
GH-623 Cleanup for PR comments.
ec472c8
@heifner
Merge pull request #627 from eosnetworkfoundation/GH-623-coma
d2a731e 
[3.1] Fix for block producer stuck in coma state
@heifner
Merge remote-tracking branch 'origin/release/3.1.x' into GH-623-to-main
1f17227
@heifner heifner requested a review from linh2931 July 9, 2022 20:15
@heifner heifner added the OCI OCI working this issue... label Jul 9, 2022
@heifner heifner merged commit 5241e96 into main Jul 11, 2022
@heifner heifner deleted the GH-623-to-main branch July 11, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI OCI working this issue...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @linh2931