Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Backport test contract fixes #622

Merged
merged 6 commits into from
Jul 9, 2022
Merged

Conversation

oschwaldp-oci
Copy link
Contributor

@oschwaldp-oci oschwaldp-oci commented Jul 7, 2022

Resolving build issues with test-contracts

Building test contracts with prior versions of mandel.cdt requires the use of a version identifier:

v1.7.x requires use of USE_EOSIO_CDT_1_7_X
v1.8.x requires use of USE_EOSIO_CDT_1_8_X
v3.0.0-rc1 and beyond does not require special parameters.

Build command argument example for building with mandel.cdt v1.7.0

cmake -DUSE_EOSIO_CDT_1_7_X=true -DEOSIO_COMPILE_TEST_CONTRACTS=true -DCMAKE_BUILD_TYPE=RelWithDebInfo ..

Resolves: #459

Backports: EOSIO/eos#9114
Backports: EOSIO/eos#9390

@oschwaldp-oci oschwaldp-oci requested a review from heifner July 7, 2022 22:45
@oschwaldp-oci oschwaldp-oci added 3.2 Candidate OCI OCI working this issue... labels Jul 7, 2022
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test with both eosio/cdt 1.7 and mandel/cdt?
Update the PR description with known supported cdt versions.

unittests/CMakeLists.txt Outdated Show resolved Hide resolved
unittests/CMakeLists.txt Outdated Show resolved Hide resolved
@oschwaldp-oci oschwaldp-oci requested a review from heifner July 9, 2022 02:25
@oschwaldp-oci oschwaldp-oci merged commit d786299 into main Jul 9, 2022
@oschwaldp-oci oschwaldp-oci deleted the backport-test-contract-fixes branch July 9, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Candidate OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport: test contract fixes
4 participants