[3.2] simplify deep_mine_tests by replacing complicated merge and match with straight-forward file copying and comparison #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h straight-forward file saving and comparison, made possible by PR #383's fix of non-determinism of deep-mind logger
swatanabe
reviewed
Jul 5, 2022
unittests/deep_mind_tests.cpp
Outdated
| { | ||
| BOOST_TEST(false, "Expected end of file at line " << i); | ||
| BOOST_TEST(false, "Expected end of file1 at line1 " << i); |
There was a problem hiding this comment.
this is a string, not a variable name.
There was a problem hiding this comment.
Thanks @swatanabe. I modified the wording.
unittests/deep_mind_tests.cpp
Outdated
Comment on lines
59
to
60
| while(std::getline(input_file, s)) { | ||
| output_file << s << "\n"; |
There was a problem hiding this comment.
Can use output_file << input_file.rdbuf() or just fc::copy and get rid of the streams entirely.
There was a problem hiding this comment.
Thanks for the suggestion. It further simplifies the code. I changed to use fc:rename as fc:copy does not allow destination to exist before copying.
arhag
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #384
#383 fixed non-determinism issues with deep-mind logger by zeroing out the elapsed fields within a copy of the transaction trace before writing it out to the logs in tests. I have confirmed that fix produced deterministic logs. The complicated merge and match code in deep_mine_tests are replaced with simple file copying and comparison.