Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Backport: Fix build when build path has spaces for mandel and appbase #565

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

linh2931
Copy link
Member

Backport EOSIO/eos#9160. Resolve #424.

EOSIO/eos#9160 contained fixes for EOSIO, appbase, and eosio-wasm-spec-tests. The fix for eosio-wasm-spec-tests was already in historical-v2.1.x and main; no further work is required for that. This PR only pulls in changes from EOSIO and appbase.

@linh2931 linh2931 requested review from heifner and spoonincode June 29, 2022 17:07
@linh2931 linh2931 self-assigned this Jun 29, 2022
Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to be clear only fixes literally the build, maybe one day stuff like tests will work too

@linh2931 linh2931 merged commit 8c24959 into main Jun 29, 2022
@linh2931 linh2931 deleted the fix_build_path_spaces branch June 29, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport: fix build when build path has spaces
2 participants