Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Add logs to artifacts #550

Merged
merged 7 commits into from
Jul 5, 2022
Merged

[3.2] Add logs to artifacts #550

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39538b5
GH-139 Add logs to artifacts
heifner Jun 28, 2022
9576766
GH-139 Fix directories of artifacts
heifner Jun 28, 2022
2e0e164
Merge remote-tracking branch 'origin/main' into save-logs
heifner Jun 28, 2022
046dd03
GH-139 Provide unique name for each set of logs
heifner Jun 29, 2022
c12aae8
GH-139 Copy logs to avoid permission issues and use if: always() so t…
heifner Jul 1, 2022
37dfc77
GH-139 Only upload logs on failure.
heifner Jul 2, 2022
df64133
GH-139 tar gzip up the logs for upload.
heifner Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions .github/workflows/ubuntu-2004.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -j $(nproc) -LE "nonparallelizable_tests|long_running_tests|wasm_spec_tests"'
- uses: actions/upload-artifact@v3
linh2931 marked this conversation as resolved.
Show resolved Hide resolved
with:
name: parallel-logs
path: |
build/var/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went to the artifacts page https://github.com/eosnetworkfoundation/mandel/actions/runs/2580037524#artifacts for this PR's CICD and downloaded forked-chain-logs and irreversible-logs. I only saw var/subprocess_results.log and etc/eosio/launcher/testnet.template. I did not see directories like var/lib/node_00, etc/eosio/node_00, ...

Not sure you need to specify all the directory levels like build/var/lib/*/* to get build/var/lib/node_00, or just build to get the whole directory. Or those node directories were somehow deleted.

Copy link
Member Author

@heifner heifner Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are cleaned up by the tests on successful runs. We might choose to add --keep-logs to our tests in the future so they are preserved for successful runs, but we do not currently do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just kicked off: #567 so we can verify logs are saved on failed tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see logs for the failed tests in https://github.com/eosnetworkfoundation/mandel/actions/runs/2586917690#artifacts.

build/etc/*
build/ctest-output.log
ubuntu-2004-wasm-test:
name: Ubuntu 20.04 | WASM Spec Test
runs-on: ubuntu-latest
Expand All @@ -175,6 +182,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -j $(nproc) -L "wasm_spec_tests" -E "conversions.*|f32.*|f64.*|unreachable.*|const.*"'
- uses: actions/upload-artifact@v3
with:
name: wasm-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
ubuntu-2004-wasm-test-2:
name: Ubuntu 20.04 | WASM Spec Test 2
runs-on: ubuntu-latest
Expand All @@ -196,6 +210,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -j $(nproc) -L "wasm_spec_tests" -R "conversions.*|f32.*|f64.*|unreachable.*|const.*"'
- uses: actions/upload-artifact@v3
with:
name: wasm-logs-2
path: |
build/var/*
build/etc/*
build/ctest-output.log
ubuntu-2004-serial-test:
name: Ubuntu 20.04 | Serial Test
runs-on: ubuntu-latest
Expand All @@ -218,6 +239,13 @@ jobs:
docker pull ${UBUNTU_2004_IMAGE}
echo =====
${DOCKER} bash -c 'cd build && ctest --output-on-failure -L "nonparallelizable_tests"'
- uses: actions/upload-artifact@v3
with:
name: serial-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
ubuntu-2004-long-test:
name: Ubuntu 20.04 | Long-Running Test
runs-on: ubuntu-latest
Expand All @@ -239,6 +267,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -L "long_running_tests" -E "nodeos_short_fork_take_over_lr_test|nodeos_under_min_avail_ram_lr_test|nodeos_startup_catchup_lr_test|nodeos_producer_watermark_lr_test|nodeos_irreversible_mode_lr_test|nodeos_forked_chain_lr_test|nodeos_voting_lr_test|nodeos_high_transaction_lr_test|nodeos_retry_transaction_lr_test"'
- uses: actions/upload-artifact@v3
with:
name: long-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_short_fork_take_over_lr_test:
name: Ubuntu 20.04 | nodeos_short_fork_take_over_lr_test
runs-on: ubuntu-latest
Expand All @@ -260,6 +295,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_short_fork_take_over_lr_test'
- uses: actions/upload-artifact@v3
with:
name: short-fork-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_under_min_avail_ram_lr_test:
name: Ubuntu 20.04 | nodeos_under_min_avail_ram_lr_test
runs-on: ubuntu-latest
Expand All @@ -281,6 +323,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_under_min_avail_ram_lr_test'
- uses: actions/upload-artifact@v3
with:
name: min-avail-ram-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_startup_catchup_lr_test:
name: Ubuntu 20.04 | nodeos_startup_catchup_lr_test
runs-on: ubuntu-latest
Expand All @@ -302,6 +351,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_startup_catchup_lr_test'
- uses: actions/upload-artifact@v3
with:
name: startup-catchup-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_producer_watermark_lr_test:
name: Ubuntu 20.04 | nodeos_producer_watermark_lr_test
runs-on: ubuntu-latest
Expand All @@ -323,6 +379,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_producer_watermark_lr_test'
- uses: actions/upload-artifact@v3
with:
name: producer-watermark-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_irreversible_mode_lr_test:
name: Ubuntu 20.04 | nodeos_irreversible_mode_lr_test
runs-on: ubuntu-latest
Expand All @@ -344,6 +407,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_irreversible_mode_lr_test'
- uses: actions/upload-artifact@v3
with:
name: irreversible-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_forked_chain_lr_test:
name: Ubuntu 20.04 | nodeos_forked_chain_lr_test
runs-on: ubuntu-latest
Expand All @@ -365,6 +435,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_forked_chain_lr_test'
- uses: actions/upload-artifact@v3
with:
name: forked-chain-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_voting_lr_test:
name: Ubuntu 20.04 | nodeos_voting_lr_test
runs-on: ubuntu-latest
Expand All @@ -386,6 +463,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_voting_lr_test'
- uses: actions/upload-artifact@v3
with:
name: voting-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_high_transaction_lr_test:
name: Ubuntu 20.04 | nodeos_high_transaction_lr_test
runs-on: ubuntu-latest
Expand All @@ -407,6 +491,13 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_high_transaction_lr_test'
- uses: actions/upload-artifact@v3
with:
name: high-trx-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log
nodeos_retry_transaction_lr_test:
name: Ubuntu 20.04 | nodeos_retry_transaction_lr_test
runs-on: ubuntu-latest
Expand All @@ -428,3 +519,10 @@ jobs:
export DOCKER="docker run --rm -v ${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE} -w ${GITHUB_WORKSPACE} ${UBUNTU_2004_IMAGE}"
docker pull ${UBUNTU_2004_IMAGE}
${DOCKER} bash -c 'cd build && ctest --output-on-failure -R nodeos_retry_transaction_lr_test'
- uses: actions/upload-artifact@v3
with:
name: retry-trx-logs
path: |
build/var/*
build/etc/*
build/ctest-output.log