Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] cleos Http 1.1 support and improves response handling #533

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

linh2931
Copy link
Member

Backport EOSIO/eos#9349
Resolve #430

From the original PR:

  • Upgrades cleos http 1.0 to 1.1: in more advanced cloud stacks cleos is being rejected by gateways or proxies with HTTP status 426:
    The HTTP 426 Upgrade Required client error response code indicates that the server refuses to perform the request using the current protocol but might be willing to do so after the client upgrades to a different protocol. The server sends an Upgrade header with this response to indicate the required protocol(s).

  • Removes unnecessary json parsing if it's an error code

  • Straight dump responses for --print-response if unable to convert to variant

@linh2931 linh2931 requested review from heifner and spoonincode June 24, 2022 19:28
@linh2931 linh2931 self-assigned this Jun 24, 2022
@linh2931 linh2931 merged commit 161c8da into main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport: Adds HTTP/1.1 support on cleos requests and improves response handling
4 participants