[3.1] pinned_build.sh - prints out warning only if the platorm is not Ubuntu and makes build directory relative to where the build starts #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectory relative to where the build starts - 3.1
spoonincode
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#363 reports
pinned_build.shalways prints "Currently only supporting Ubuntu based builds. Proceed at your own risk.", even on Ubuntu platform.#364 reports the build directory is made relative to the dependency directory; it should have been relative to the directory where the script starts.
This PR fixes those two issues.
Tested in two different directories: