[3.2] Backport push_transaction optimizations. #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Jun 22, 2022
spoonincode
reviewed
Jun 22, 2022
libraries/chain/controller.cpp
Outdated
| vector<transaction_metadata_ptr> _pending_trx_metas; | ||
| vector<transaction_receipt> _pending_trx_receipts; | ||
| vector<digest_type> _action_receipt_digests; | ||
| deque<transaction_metadata_ptr> _pending_trx_metas; |
There was a problem hiding this comment.
seems like the whitespace could have been fixed up on all these
There was a problem hiding this comment.
Cleaned up indentation.
spoonincode
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize push_transaction by using deque instead of vector to avoid vector having to reallocate and move transaction receipts and max transaction metas in block.
std::deque used for boost < 1.71 now since configurable boost::container::deque is not available until boost 1.71. boost deque used if boost >= 1.71 available.
Calculate action_receipt digest at action execution time to avoid copying of action_receipts and to bill for hash.
Calculate transaction_receipt digest at transaction execution time to bill for hash.
Resolves: #358