Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes need to crypto-primitives host functions #471

Closed
wants to merge 6 commits into from
Closed

Changes need to crypto-primitives host functions #471

wants to merge 6 commits into from

Conversation

larryk85
Copy link
Contributor

See issue #470

@larryk85 larryk85 requested review from arhag and spoonincode June 20, 2022 21:59
@spoonincode
Copy link
Member

I think will need the deepmind test fixed up since changed protocol feature hash

@arhag
Copy link
Member

arhag commented Jun 21, 2022

Yes. In addition to updating the deep mind log, the hash in plugin_http_api_test also needs to be updated.

@larryk85 larryk85 changed the base branch from main to release/3.1.x June 22, 2022 13:39
@larryk85 larryk85 changed the base branch from release/3.1.x to main June 22, 2022 13:40
@larryk85
Copy link
Contributor Author

Need to rebase to release/3.1.x and I am going to try to regen the dm logs again.

@larryk85 larryk85 closed this Jun 22, 2022
@larryk85 larryk85 deleted the larryk85/crypto-primitives-changes branch June 22, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag left review comments

@spoonincode spoonincode Awaiting requested review from spoonincode

Assignees
No one assigned
Labels
3.1 RC2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larryk85 @spoonincode @arhag