Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport dfuse support #38

Merged
merged 13 commits into from
Mar 17, 2022
Merged

Backport dfuse support #38

merged 13 commits into from
Mar 17, 2022

Conversation

swatanabe
Copy link
Contributor

No description provided.

@maoueh
Copy link
Contributor

maoueh commented Feb 11, 2022

@swatanabe I would like to probably update the DEEP_MIND_VERSION line to print some kind of identifier for the "fork". The deep mind code internal structure to forward the transaction trace and accepted block and those changed based on the version to the logger.

On the reading part, based on the version information, I'm instantiating the correct decoder. Now, probably that the fork or some identifier will be required also so I would have access to more information on the decoding part to take a decision.

Now it's look like this:

  • DEEP_MIND_VERSION 12 0 => EOSIO 2.0.x decoder
  • DEEP_MIND_VERSION 13 0 => EOSIO 2.1.x decoder
  • DEEP_MIND_VERSION 14 0 => EOSIO 2.2.x decoder

And proposition:

  • DEEP_MIND_VERSION 12 0 => EOSIO 2.0.x decoder (inferred variant eosio)

  • DEEP_MIND_VERSION 13 0 => EOSIO 2.1.x decoder (inferred variant eosio)

  • DEEP_MIND_VERSION 14 0 => EOSIO 2.2.x decoder (inferred variant eosio)

  • DEEP_MIND_VERSION mandel 13 0 => Mandel X.Y.Z decoder (probably based on 2.1.x) (variant mandel)

@swatanabe
Copy link
Contributor Author

I suspect that the transaction trace and block are using the 2.0 format. The transaction and block format was changed in 2.1 to support pruning context free data and we have not and do not intend to backport this.

@maoueh
Copy link
Contributor

maoueh commented Feb 14, 2022

The transaction and block format was changed in 2.1 to support pruning context free data and we have not and do not intend to backport this.

You still have return value right? I knew that pruning was not being ported over.

Hence why I decided to raise the "variant" in the DEEP_MIND_VERSION because now it's kind of an hybrid where it will have the return_value but not the pruning, hence I'll need dedicated structure for Mandel specifically.

@swatanabe swatanabe marked this pull request as ready for review February 18, 2022 20:16
@swatanabe swatanabe requested a review from tbfleming February 21, 2022 13:36
@swatanabe swatanabe merged commit 9b653f2 into main Mar 17, 2022
@swatanabe swatanabe deleted the dfuse branch April 19, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants