Don't apply subjective billing to read-only transactions #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Apr 20, 2022
heifner
reviewed
Apr 20, 2022
heifner
suggested changes
Apr 20, 2022
There was a problem hiding this comment.
Currently read-only transactions are signaled in controller as accepted_transaction and as applied_transaction. I think we should avoid signaling read-only transactions. Also read-only transaction traces are logged in deep-mind logger as applied. I think we should not deep-mind log them either.
heifner
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns off subjective billing for read-only transactions.
*** Warning ***
An effect of this change is that compute_transaction becomes a potential DOS attack vector for any node that has enabled the compute_transaction end point. Any exposed node should implement some form of throttling to prevent this sort of attack.