Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent access to ~/eosio-wallet/ & ~/.local/share/eosio during CI test runs #770

Closed
spoonincode opened this issue Jul 21, 2022 · 1 comment
Labels
cicd Changes related to builds and CICD

Comments

@spoonincode
Copy link
Member

Tests should never access nodeos' and keosd's default config & data directories (~/.local/share/eosio & ~/eosio-wallet respectively) . At best it can create spooky problems such as #553, in extreme cases it could remove a user's wallet (what I'm worried #704 might have done).

CI must prevent access to these directories so that tests violating this rule fail as an indicator to us that the test needs fixing.

Bonus points for using something like FUSE to make sure an application even so much as taking a sniff 👃 with opendir() will cause some sort of catastrophic test failure.

@spoonincode spoonincode added the cicd Changes related to builds and CICD label Jul 21, 2022
@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
@spoonincode
Copy link
Member Author

Transferred to Leap repo

@spoonincode spoonincode closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in ENF Engineering Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Changes related to builds and CICD
Projects
Status: Done
Development

No branches or pull requests

1 participant