Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent access to ~/eosio-wallet/ & ~/.local/share/eosio during CI test runs #619

Open
spoonincode opened this issue Jan 5, 2023 · 0 comments
Labels
CICD Anything dealing with the CI workflow behavior 👍 lgtm

Comments

@spoonincode
Copy link
Member

This is a transfer of eosnetworkfoundation/mandel#770

Tests should never access nodeos' and keosd's default config & data directories (~/.local/share/eosio & ~/eosio-wallet respectively) . At best it can create spooky problems such as eosnetworkfoundation/mandel#553, in extreme cases it could remove a user's wallet (what I'm worried eosnetworkfoundation/mandel#704 might have done in very specific conditions).

CI must prevent access to these directories so that tests violating this rule fail as an indicator to us that the test needs fixing.

Bonus points for using something like FUSE to make sure an application even so much as taking a sniff 👃 with opendir() will cause some sort of catastrophic test failure.

@spoonincode spoonincode added the CICD Anything dealing with the CI workflow behavior label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD Anything dealing with the CI workflow behavior 👍 lgtm
Projects
Status: Todo
Development

No branches or pull requests

2 participants