Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: ABI serializer always saves hex_data of action data #659

Closed
linh2931 opened this issue Jul 12, 2022 · 0 comments · Fixed by #701
Closed

Backport: ABI serializer always saves hex_data of action data #659

linh2931 opened this issue Jul 12, 2022 · 0 comments · Fixed by #701
Assignees
@ndcgundlach
Milestone
Mandel 3.2.0

Comments

@linh2931
Copy link
Member

#466 attempts to back port EOSIO/eos#10100. It contains two parts: always saving raw data in hex_data field, and not saving raw data in data field if serialization fails. The second part breaks backward compatibility. It is agreed that the second part should not be pulled over, and only hex_data change should be back ported.
@linh2931 linh2931 moved this to Todo in ENF Engineering Jul 12, 2022
@linh2931 linh2931 added this to the Mandel 3.2.0-rc1 milestone Jul 12, 2022
@linh2931 linh2931 mentioned this issue Jul 12, 2022
Closed
@oschwaldp-oci oschwaldp-oci added OCI OCI working this issue... and removed OCI OCI working this issue... labels Jul 15, 2022
@ndcgundlach ndcgundlach self-assigned this Jul 19, 2022
ndcgundlach added a commit that referenced this issue Jul 20, 2022
@ndcgundlach
GH-659 backport always populate hex_data for actions
81b07f1
ndcgundlach added a commit that referenced this issue Jul 20, 2022
@ndcgundlach
GH-659 backport tests for always populate hex_data for actions
5ed2e8d
@ndcgundlach ndcgundlach moved this from Todo to Awaiting Review in ENF Engineering Jul 20, 2022
@ndcgundlach ndcgundlach mentioned this issue Jul 20, 2022
Merged
Repository owner moved this from Awaiting Review to Done in ENF Engineering Jul 20, 2022
@stephenpdeos stephenpdeos modified the milestones: Mandel 3.2.0-rc1, Mandel 3.2.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndcgundlach ndcgundlach

Labels
None yet
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.2.0
Development

Successfully merging a pull request may close this issue.

[3.2] Backport action serialization to always include hex_data. eosnetworkfoundation/mandel
4 participants
@oschwaldp-oci @ndcgundlach @stephenpdeos @linh2931